wonook commented on a change in pull request #187: [NEMO-324] Distinguish
Beam's run and waitUntilFinish methods
URL: https://github.com/apache/incubator-nemo/pull/187#discussion_r326231697
##########
File path: client/src/main/java/org/apache/nemo/client/ClientEndpoint.java
##########
@@ -109,20 +114,7 @@ private boolean waitUntilConnected(final long timeout,
* @return {@code true} if the manager set.
*/
private boolean waitUntilConnected() {
- connectionLock.lock();
- try {
- if (driverEndpoint.get() == null) {
- // If the driver endpoint is not connected, wait.
- driverConnected.await();
- }
- return true;
- } catch (final InterruptedException e) {
- e.printStackTrace(System.err);
- Thread.currentThread().interrupt();
- return false;
- } finally {
- connectionLock.unlock();
- }
+ return waitUntilConnected(0, TimeUnit.MILLISECONDS);
Review comment:
It's not used at the moment, but I think it's correct to guide the users to
some point where there is no timeout with the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
