johnyangk commented on a change in pull request #222: [NEMO-350] Implement
Off-heap SerializedMemoryStore & [NEMO-384] Implement
DirectByteBufferInputStream for Off-heap SerializedMemoryStore
URL: https://github.com/apache/incubator-nemo/pull/222#discussion_r295140584
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/bytetransfer/ByteOutputContext.java
##########
@@ -157,12 +161,37 @@ public void write(final byte[] bytes, final int offset,
final int length) throws
* @return {@code this}
* @throws IOException when an exception has been set or this stream was
closed
*/
- public ByteOutputStream writeSerializedPartition(final SerializedPartition
serializedPartition)
+ public ByteOutputStream writeSerializedPartitionBuffer(final
SerializedPartition serializedPartition)
throws IOException {
- write(serializedPartition.getData(), 0, serializedPartition.getLength());
Review comment:
Does write() get used from anywhere after this change? I skimmed through and
could not find it. If write() is no longer being used, then can you remove
`extends OutputStream` to reduce confusion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
