johnyangk commented on a change in pull request #222: [NEMO-350] Implement
Off-heap SerializedMemoryStore & [NEMO-384] Implement
DirectByteBufferInputStream for Off-heap SerializedMemoryStore
URL: https://github.com/apache/incubator-nemo/pull/222#discussion_r295153193
##########
File path:
common/src/main/java/org/apache/nemo/common/DirectByteBufferOutputStream.java
##########
@@ -31,11 +32,10 @@
public final class DirectByteBufferOutputStream extends OutputStream {
Review comment:
When is `dataList` deleted and when is the memory released, especially since
the memory used is allocated off heap?
Do we still comply with the `DataPersistenceProperty`? (i.e., delete
intermediate data once used)
Can you add comments perhaps in this class and others such as
`SerializedPartition` to clarify this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
