johnyangk commented on a change in pull request #223: [NEMO-388] Off-heap
memory management (reuse ByteBuffer)
URL: https://github.com/apache/incubator-nemo/pull/223#discussion_r306160056
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/partition/SerializedPartition.java
##########
@@ -226,4 +236,11 @@ public int getLength() throws IOException {
public boolean isOffheap() {
return offheap;
}
+
+ /**
+ * Releases the off-heap memory that this SerializedPartition holds.
+ */
+ public void release() {
+ bytesOutputStream.release();
Review comment:
Shouldn't this be called upon commit()?
write(): writes to the stream
commit(): obtains the materialized data from the stream
getData(): returns the data
Given the above, I'd think that release() operates on the data, not the
stream.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
