johnyangk commented on a change in pull request #223: [NEMO-388] Off-heap 
memory management (reuse ByteBuffer)
URL: https://github.com/apache/incubator-nemo/pull/223#discussion_r307127039
 
 

 ##########
 File path: 
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/stores/AbstractBlockStore.java
 ##########
 @@ -48,4 +53,13 @@ protected final Serializer getSerializerFromWorker(final 
String blockId) {
     final String runtimeEdgeId = 
RuntimeIdManager.getRuntimeEdgeIdFromBlockId(blockId);
 
 Review comment:
   Ditto on protected. (one line above)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to