johnyangk commented on a change in pull request #223: [NEMO-388] Off-heap
memory management (reuse ByteBuffer)
URL: https://github.com/apache/incubator-nemo/pull/223#discussion_r307125786
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/block/NonSerializedMemoryBlock.java
##########
@@ -166,9 +172,13 @@ public void writeSerializedPartitions(final
Iterable<SerializedPartition<K>> par
@Override
public Iterable<SerializedPartition<K>> readSerializedPartitions(final
KeyRange keyRange) throws BlockFetchException {
try {
- return DataUtil.convertToSerPartitions(serializer,
readPartitions(keyRange));
+ return DataUtil.convertToSerPartitions(serializer,
readPartitions(keyRange), memoryPoolAssigner);
} catch (final IOException e) {
throw new BlockFetchException(e);
+ } catch (final IllegalAccessException e) {
Review comment:
Ditto on catching multiple exceptions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
