johnyangk commented on a change in pull request #223: [NEMO-388] Off-heap
memory management (reuse ByteBuffer)
URL: https://github.com/apache/incubator-nemo/pull/223#discussion_r310478526
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/partition/SerializedPartition.java
##########
@@ -226,4 +241,14 @@ public int getLength() throws IOException {
public boolean isOffheap() {
return offheap;
}
+
+ /**
+ * Releases the off-heap memory that this SerializedPartition holds.
+ */
+ public void release() {
Review comment:
What do you think about adding a JIRA issue and adding a TODO here as a
pointer?
JIRA issue: Consider removing 'transient' uses of SerializedPartition. Use
SerializedPartition only for SerializedMemoryStore. FileBlock and
ByteOutputContext should write directly to disks/network, and not create
intermediary SerializedPartitions and do extra copying. This also simplifies
the uses of SerializedPartition#release().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
