alapha23 commented on a change in pull request #231: [NEMO-406] Invoke LambdaExecutor without creating containers URL: https://github.com/apache/incubator-nemo/pull/231#discussion_r315433537
########## File path: runtime/master/src/main/java/org/apache/nemo/runtime/master/RuntimeMaster.java ########## @@ -115,6 +110,8 @@ private final Server metricServer; private final MetricStore metricStore; + private static LambdaMaster lambdaMaster; Review comment: `private final` will require us to initialize the variable in RuntimeMaster constructor. I was hoping to keep changes to RuntimeMaster minimal. I'm not sure whether moving lambdaMaster initialization to constructor is a good idea. What do you think? Is it a good idea to move lambdaMaster initialization to constructor? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
