alapha23 commented on a change in pull request #231: [NEMO-406] Invoke
LambdaExecutor without creating containers
URL: https://github.com/apache/incubator-nemo/pull/231#discussion_r315434270
##########
File path:
runtime/master/src/main/java/org/apache/nemo/runtime/master/RuntimeMaster.java
##########
@@ -332,6 +331,28 @@ public void requestContainer(final String
resourceSpecificationString) {
}
}
+ /**
+ * Requests a lambda executor.
+ */
+ public void requestLambdaExecutor() {
+ final ExecutorRepresenter executorRepresenter;
+ final String executorId = RuntimeIdManager.generateExecutorId();
+ final String nodeName = "192.168.0.100";
+
+ // LambdaRuntimeMaster manages Netty Server for LambdaExecutor to connect
to
+ // Set up netty server at port 9999, and registers handler
+ this.lambdaMaster = new LambdaMaster();
Review comment:
I think we have too many parameters in RuntimeMaster, making it harder to
read and maintain.
In the future, we should allow LambdaMaster to search for available open
port to use, so anyway we won't need a static port variable in RuntimeMaster.
So I think it's better to keep `port` only inside the LambdaMaster class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
