johnyangk commented on a change in pull request #232: [NEMO-411] Bug in
ScheduleGroupPass, OutputTag, DuplicateEdgeGroup
URL: https://github.com/apache/incubator-nemo/pull/232#discussion_r327456883
##########
File path:
compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/pass/compiletime/annotating/DefaultScheduleGroupPass.java
##########
@@ -113,7 +112,11 @@ public IRDAG apply(final IRDAG dag) {
groupIdToVertices.putIfAbsent(curId, new ArrayList<>());
groupIdToVertices.get(curId).add(irVertex);
- final List<IREdge> allOutEdges = dag.getOutgoingEdgesOf(irVertex);
+ final List<IRVertex> verticesOfGroup = groupIdToVertices.get(curId);
+ final List<IREdge> allOutEdges = groupIdToVertices.get(curId).stream()
Review comment:
allOutEdgesOfGroup?
Can you also leave a comment that this doesn't count edges between vertices
in the group?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
