johnyangk commented on a change in pull request #232: [NEMO-411] Bug in
ScheduleGroupPass, OutputTag, DuplicateEdgeGroup
URL: https://github.com/apache/incubator-nemo/pull/232#discussion_r368825782
##########
File path: common/src/main/java/org/apache/nemo/common/ir/IRDAGChecker.java
##########
@@ -348,8 +349,12 @@ void addStreamVertexCheckers() {
}
void addLoopVertexCheckers() {
+ final AtomicInteger distinctIntegerForEmptyOutputTag = new
AtomicInteger(0);
Review comment:
Can you add a comment on why this is needed for loops, and why the existing
private method, groupOutEdgesByAdditionalOutputTag, can't be used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
