hy00nc commented on a change in pull request #278: [NEMO-429] SWPP TEAM16 Code Smell Fix URL: https://github.com/apache/incubator-nemo/pull/278#discussion_r353538058
########## File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/block/FileBlock.java ########## @@ -69,6 +69,7 @@ private final String filePath; private final FileMetadata<K> metadata; private final MemoryPoolAssigner memoryPoolAssigner; + private final static String alreadyCommited = "The partition is already committed!"; Review comment: The naming convention for a final static variable is to write them in capital letters. It would be better to rename it to `ALREADY_COMMITTED` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
