hy00nc commented on a change in pull request #278: [NEMO-429] SWPP TEAM16 Code
Smell Fix
URL: https://github.com/apache/incubator-nemo/pull/278#discussion_r353538437
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/CreateViewTransform.java
##########
@@ -40,7 +40,8 @@
*/
public final class CreateViewTransform<I, O> implements
Transform<WindowedValue<KV<?, I>>, WindowedValue<O>> {
private final ViewFn<Materializations.MultimapView<Void, ?>, O> viewFn;
- private final Map<BoundedWindow, List<I>> windowListMap;
+
+ private final transient Map<BoundedWindow, List<I>> windowListMap;
Review comment:
Please just remove the transient keyword and leave it untouched. This is
rather a complex issue, so let's not resolve it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services