wynot12 commented on a change in pull request #259: [NEMO-429] SWPP TEAM 9 code
smell fix
URL: https://github.com/apache/incubator-nemo/pull/259#discussion_r354694514
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/BlockManagerWorker.java
##########
@@ -233,9 +233,9 @@ public Block createBlock(final String blockId,
blockTransferThrottler.onTransferFinished(runtimeEdgeId);
} else {
// Connection is okay. Notify blockTransferThrottler when the
actual transfer is done, or fails.
-
connectionContext.getCompletedFuture().whenComplete((transferContext,
transferThrowable) -> {
+
connectionContext.getCompletedFuture().whenComplete((transferContext,
transferThrowable) ->
blockTransferThrottler.onTransferFinished(runtimeEdgeId);
Review comment:
You should remove `;` at the end of this line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
