wynot12 commented on a change in pull request #259: [NEMO-429] SWPP TEAM 9 code
smell fix
URL: https://github.com/apache/incubator-nemo/pull/259#discussion_r354694203
##########
File path: client/src/main/java/org/apache/nemo/client/ClientUtils.java
##########
@@ -47,9 +47,8 @@ private ClientUtils() {
*/
static void handleOptimizationType(final
ControlMessage.DriverToClientMessage message,
final DriverRPCServer driverRPCServer) {
- switch (message.getOptimizationType()) {
- case XGBoost:
- new Thread(() ->
+ if(message.getOptimizationType()==XGBoost){
Review comment:
Please use `equals()` to compare two enum values.
And would you please insert some spaces like the following?
`if (message.getOptimizationType().equals(XGBoost)) {`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
