DifferentSC commented on a change in pull request #279: [NEMO-420]
OffHeapMemory configuration only supports a single type of executor
URL: https://github.com/apache/incubator-nemo/pull/279#discussion_r367203843
##########
File path:
runtime/executor/src/test/java/org/apache/nemo/runtime/executor/data/BlockStoreTest.java
##########
@@ -229,7 +229,7 @@ public void setUp() throws Exception {
public void testMemoryStore() throws Exception {
final Injector injector = Tang.Factory.getTang().newInjector();
injector.bindVolatileInstance(SerializerManager.class, serializerManager);
- injector.bindVolatileParameter(JobConf.MaxOffheapMb.class, 128);
+ injector.bindVolatileParameter(JobConf.ExecutorMemoryMb.class, 640);
Review comment:
I think it would be more readable if we specify the `MaxOffheapRatio` to
`0.2`. Others may not be aware of the default value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
