polarcoke2 commented on a change in pull request #279: [NEMO-420] OffHeapMemory 
configuration only supports a single type of executor
URL: https://github.com/apache/incubator-nemo/pull/279#discussion_r367235793
 
 

 ##########
 File path: 
runtime/master/src/main/java/org/apache/nemo/runtime/master/resource/ResourceSpecification.java
 ##########
 @@ -29,22 +31,25 @@
   private final String containerType;
   private final int capacity;
   private final int memory;
-  private final int poisonSec; // -1 if this resources is not poisoned
+  private final Optional<Double> maxOffheapRatio;
+  private final Optional<Integer> poisonSec; // -1 if this resources is not 
poisoned
 
 Review comment:
   done! thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to