polarcoke2 commented on a change in pull request #292: URL: https://github.com/apache/incubator-nemo/pull/292#discussion_r443460178
########## File path: compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/pass/compiletime/reshaping/SamplingTaskSizingPass.java ########## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.nemo.compiler.optimizer.pass.compiletime.reshaping; + +import org.apache.nemo.common.Util; +import org.apache.nemo.common.dag.Edge; +import org.apache.nemo.common.ir.IRDAG; +import org.apache.nemo.common.ir.edge.IREdge; +import org.apache.nemo.common.ir.edge.executionproperty.*; +import org.apache.nemo.common.ir.vertex.IRVertex; +import org.apache.nemo.common.ir.vertex.executionproperty.EnableDynamicTaskSizingProperty; +import org.apache.nemo.common.ir.vertex.executionproperty.ParallelismProperty; +import org.apache.nemo.common.ir.vertex.utility.TaskSizeSplitterVertex; +import org.apache.nemo.common.ir.vertex.utility.runtimepasstriggervertex.SignalVertex; +import org.apache.nemo.compiler.optimizer.pass.compiletime.annotating.Annotates; +import org.apache.nemo.runtime.common.plan.StagePartitioner; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.*; +import java.util.function.Predicate; +import java.util.stream.Collectors; + +/** + * Compiler pass for dynamic task size optimization. Happens only when the edge property is SHUFFLE. + * If (size of given job) >= 1GB: enable dynamic task sizing optimization. + * else: break. + * + * + * @Attributes + * PARTITIONER_PROPERTY_FOR_SMALL_JOB: PartitionerProperty for jobs in range of [1GB, 10GB) size. + * PARTITIONER_PROPERTY_FOR_MEDIUM_JOB: PartitionerProperty for jobs in range of [10GB, 100GB) size. + * PARTITIONER_PROPERTY_FOR_BIG_JOB: PartitionerProperty for jobs in range of [100GB, - ) size(No upper limit). + * + * source stage - shuffle edge - current stage - next stage + * -> source stage - [curr stage - signal vertex] - next stage + * where [] is a splitter vertex + */ +@Annotates({EnableDynamicTaskSizingProperty.class, PartitionerProperty.class, SubPartitionSetProperty.class, + ParallelismProperty.class}) +public final class SamplingTaskSizingPass extends ReshapingPass { + private static final Logger LOG = LoggerFactory.getLogger(SamplingTaskSizingPass.class.getName()); + + private static final int PARTITIONER_PROPERTY_FOR_SMALL_JOB = 1024; + private static final int PARTITIONER_PROPERTY_FOR_MEDIUM_JOB = 2048; + private static final int PARTITIONER_PROPERTY_FOR_BIG_JOB = 4096; + private final StagePartitioner stagePartitioner = new StagePartitioner(); + + /** + * Default constructor. + */ + public SamplingTaskSizingPass() { + super(SamplingTaskSizingPass.class); + } + + @Override + public IRDAG apply(final IRDAG dag) { + /* Step 1. check DTS launch by job size */ + boolean enableDynamicTaskSizing = getEnableFromJobSize(dag); + if (!enableDynamicTaskSizing) { + dag.topologicalDo(v -> { + v.setProperty(EnableDynamicTaskSizingProperty.of(enableDynamicTaskSizing)); + for (IREdge e : dag.getIncomingEdgesOf(v)) { // do we need this? erase this code and check results + if (!CommunicationPatternProperty.Value.ONE_TO_ONE.equals( + e.getPropertyValue(CommunicationPatternProperty.class).get())) { + final int partitionerProperty = e.getDst().getPropertyValue(ParallelismProperty.class).get(); + e.setPropertyPermanently(PartitionerProperty.of( + e.getPropertyValue(PartitionerProperty.class).get().left(), partitionerProperty)); + } + } + }); + return dag; + } else { + dag.topologicalDo(v -> { + v.setProperty(EnableDynamicTaskSizingProperty.of(enableDynamicTaskSizing)); + }); + } + + final int partitionerProperty = setPartitionerProperty(dag); + + /* Step 2-1. Group vertices by stage using stage merging logic */ + final Map<IRVertex, Integer> vertexToStageId = stagePartitioner.apply(dag); + final Map<Integer, Set<IRVertex>> stageIdToStageVertices = new HashMap<>(); + vertexToStageId.forEach((vertex, stageId) -> { + if (!stageIdToStageVertices.containsKey(stageId)) { + stageIdToStageVertices.put(stageId, new HashSet<>()); + } + stageIdToStageVertices.get(stageId).add(vertex); + }); + + /* Step 2-2. Mark stages to insert splitter vertex and get target edges of DTS */ + Set<Integer> stageIdsToInsertSplitter = new HashSet<>(); + Set<IREdge> shuffleEdgesForDTS = new HashSet<>(); + dag.topologicalDo(v -> { + for (final IREdge edge : dag.getIncomingEdgesOf(v)) { + if (checkForInsertingSplitterVertex(dag, v, edge, vertexToStageId, stageIdToStageVertices)) { + stageIdsToInsertSplitter.add(vertexToStageId.get(v)); + shuffleEdgesForDTS.add(edge); + } + } + }); + + /* Step 2-3. Change partitioner property for DTS target edges */ + dag.topologicalDo(v -> { + for (final IREdge edge : dag.getIncomingEdgesOf(v)) { + if (shuffleEdgesForDTS.contains(edge)) { + shuffleEdgesForDTS.remove(edge); + edge.setProperty(PartitionerProperty.of(PartitionerProperty.Type.HASH, partitionerProperty)); + shuffleEdgesForDTS.add(edge); + } + } + }); + /* Step 3. Insert Splitter Vertex */ + List<IRVertex> reverseTopologicalOrder = dag.getTopologicalSort(); + Collections.reverse(reverseTopologicalOrder); + for (IRVertex v : reverseTopologicalOrder) { + for (final IREdge edge : dag.getOutgoingEdgesOf(v)) { + if (shuffleEdgesForDTS.contains(edge)) { + // edge is the incoming edge of observing stage, v is the last vertex of previous stage + Set<IRVertex> stageVertices = stageIdToStageVertices.get(vertexToStageId.get(edge.getDst())); + Set<IRVertex> verticesWithStageOutgoingEdges = stageVertices.stream().filter(stageVertex -> + dag.getOutgoingEdgesOf(stageVertex).stream() + .map(Edge::getDst).anyMatch(Predicate.not(stageVertices::contains))) + .collect(Collectors.toSet()); + Set<IRVertex> stageEndingVertices = stageVertices.stream() + .filter(stageVertex -> dag.getOutgoingEdgesOf(stageVertex).isEmpty() + || !dag.getOutgoingEdgesOf(stageVertex).stream().map(Edge::getDst).anyMatch(stageVertices::contains)) + .collect(Collectors.toSet()); + final boolean isSourcePartition = stageVertices.stream() + .flatMap(vertexInPartition -> dag.getIncomingEdgesOf(vertexInPartition).stream()) + .map(Edge::getSrc) + .allMatch(stageVertices::contains); + if (isSourcePartition) { + break; + } + makeAndInsertSplitterVertex(dag, stageVertices, Collections.singleton(edge.getDst()), + verticesWithStageOutgoingEdges, stageEndingVertices, partitionerProperty); + } + } + } + return dag; + } + + private boolean getEnableFromJobSize(final IRDAG dag) { + long jobSizeInBytes = dag.getInputSize(); + return jobSizeInBytes >= 1024 * 1024 * 1024; + } + + /** + * should be called after EnableDynamicTaskSizingProperty is declared as true. + * @param dag IRDAG to get job input data size from + * @return partitioner property regarding job size + */ + private int setPartitionerProperty(final IRDAG dag) { Review comment: Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
