polarcoke2 commented on a change in pull request #292: URL: https://github.com/apache/incubator-nemo/pull/292#discussion_r446536292
########## File path: compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/pass/compiletime/reshaping/SamplingTaskSizingPass.java ########## @@ -0,0 +1,461 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.nemo.compiler.optimizer.pass.compiletime.reshaping; + +import org.apache.nemo.common.Util; +import org.apache.nemo.common.dag.Edge; +import org.apache.nemo.common.ir.IRDAG; +import org.apache.nemo.common.ir.edge.IREdge; +import org.apache.nemo.common.ir.edge.executionproperty.*; +import org.apache.nemo.common.ir.vertex.IRVertex; +import org.apache.nemo.common.ir.vertex.executionproperty.EnableDynamicTaskSizingProperty; +import org.apache.nemo.common.ir.vertex.executionproperty.ParallelismProperty; +import org.apache.nemo.common.ir.vertex.utility.TaskSizeSplitterVertex; +import org.apache.nemo.common.ir.vertex.utility.runtimepass.SignalVertex; +import org.apache.nemo.compiler.optimizer.pass.compiletime.annotating.Annotates; +import org.apache.nemo.runtime.common.plan.StagePartitioner; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.*; +import java.util.stream.Collectors; + +/** + * Compiler pass for dynamic task size optimization. Happens only when the edge property is SHUFFLE. + * If (size of given job) >= 1GB: enable dynamic task sizing optimization. + * else: break. + * + * + * @Attributes + * PARTITIONER_PROPERTY_FOR_SMALL_JOB: PartitionerProperty for jobs in range of [1GB, 10GB) size. + * PARTITIONER_PROPERTY_FOR_MEDIUM_JOB: PartitionerProperty for jobs in range of [10GB, 100GB) size. + * PARTITIONER_PROPERTY_FOR_BIG_JOB: PartitionerProperty for jobs in range of [100GB, - ) size(No upper limit). + * + * source stage - shuffle edge - current stage - next stage + * -> source stage - [curr stage - signal vertex] - next stage + * where [] is a splitter vertex + */ +@Annotates({EnableDynamicTaskSizingProperty.class, PartitionerProperty.class, SubPartitionSetProperty.class, + ParallelismProperty.class}) +public final class SamplingTaskSizingPass extends ReshapingPass { Review comment: Would it be alright if I add test cases for this pass after creating corresponding runtime pass with this? This pass includes adding Signal Vertex to the DAG, and since it's job is to trigger runtime pass, I think it would be better to test this pass with runtime pass together with one policy. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
