taegeonum commented on a change in pull request #299:
URL: https://github.com/apache/incubator-nemo/pull/299#discussion_r503669801
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GBKTransform.java
##########
@@ -235,6 +234,7 @@ private void triggerTimers(final Instant processingTime,
final Instant synchronizedTime,
final Watermark watermark) {
+ ArrayList<K> removed = new ArrayList<>();
Review comment:
Instead of creating this, we can remove the element in a while loop with
`Iterator.remove` :
https://stackoverflow.com/questions/23665098/remove-an-element-from-a-list-inside-a-loop/23665370
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GBKTransform.java
##########
@@ -235,6 +234,7 @@ private void triggerTimers(final Instant processingTime,
final Instant synchronizedTime,
final Watermark watermark) {
+ ArrayList<K> removed = new ArrayList<>();
for (Map.Entry<K, InMemoryTimerInternals> curr :
inMemoryTimerInternalsFactory.getTimerInternalsMap().entrySet()) {
Review comment:
final Map.Entry
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
