taegeonum commented on a change in pull request #299:
URL: https://github.com/apache/incubator-nemo/pull/299#discussion_r503671067
##########
File path:
compiler/test/src/test/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyAndWindowDoFnTransformTest.java
##########
@@ -88,13 +89,15 @@ public void test() {
final SlidingWindows slidingWindows =
SlidingWindows.of(Duration.standardSeconds(2))
.every(Duration.standardSeconds(1));
- final GroupByKeyAndWindowDoFnTransform<String, String> doFnTransform =
- new GroupByKeyAndWindowDoFnTransform(
+ final GBKTransform<String, String, Iterable<String>> doFnTransform =
Review comment:
Do we need `GroupByKeyAndWindowDoFnTransformTest`? Can we merge this
test with `GBKTransformTest`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
