taegeonum commented on a change in pull request #302:
URL: https://github.com/apache/incubator-nemo/pull/302#discussion_r506931008
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/PipelineTranslationContext.java
##########
@@ -275,7 +275,7 @@ DAGBuilder getBuilder() {
if (srcTransform instanceof FlattenTransform) {
return CommunicationPatternProperty.Value.ONE_TO_ONE;
}
- if (dstTransform instanceof GBKTransform
+ if ((dstTransform instanceof GBKTransform && !(dstTransform instanceof
CombineFnWindowedTransform))
Review comment:
How about adding a variable like `private final paritalCombining =
false` and getter method like `isPartialCombiner()` in `GBKTransform`? so here
we can check whether the GBKTransform is partialCombiner or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
