jaehwan0214 commented on a change in pull request #302:
URL: https://github.com/apache/incubator-nemo/pull/302#discussion_r506936271
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/PipelineTranslationContext.java
##########
@@ -275,7 +275,7 @@ DAGBuilder getBuilder() {
if (srcTransform instanceof FlattenTransform) {
return CommunicationPatternProperty.Value.ONE_TO_ONE;
}
- if (dstTransform instanceof GBKTransform
+ if ((dstTransform instanceof GBKTransform && !(dstTransform instanceof
CombineFnWindowedTransform))
Review comment:
I think that's better than the previous implementation. I'll implement
it as you described.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
