taegeonum commented on a change in pull request #304:
URL: https://github.com/apache/incubator-nemo/pull/304#discussion_r519560546
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/task/MultiThreadParentTaskDataFetcher.java
##########
@@ -127,14 +129,19 @@ private void fetchDataLazily() {
watermarkWithIndex.getIndex(),
watermarkWithIndex.getWatermark());
}
} else {
+ if (element instanceof Finishmark) {
+ isFinishMarkProduced = true;
+ }
// data element
elementQueue.offer(element);
}
}
-
// This iterator is finished.
countBytesSynchronized(iterator);
- elementQueue.offer(Finishmark.getInstance());
+ // If the current iterator hasn't produced finish mark, put it into
the global queue.
+ if (!isFinishMarkProduced) {
Review comment:
When are multiple finshmarks received?
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/transfer/LocalInputContext.java
##########
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.nemo.runtime.executor.transfer;
+
+import org.apache.nemo.common.punctuation.Finishmark;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import java.util.Iterator;
+import java.util.concurrent.ConcurrentLinkedQueue;
+
+/**
+ * This class provides a data transfer interface to the receiver side when
both the sender and the receiver are in the
+ * same executor. Since the sender doesn't serialize data, the receiver
doesn't need to deserialize data when retrieving
+ * them.
+ */
+public final class LocalInputContext extends LocalTransferContext {
+ private static final Logger LOG =
LoggerFactory.getLogger(LocalInputContext.class.getName());
+ private ConcurrentLinkedQueue queue;
Review comment:
Why not final?
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/transfer/LocalOutputContext.java
##########
@@ -0,0 +1,109 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.nemo.runtime.executor.transfer;
+
+import org.apache.nemo.common.punctuation.Finishmark;
+import org.apache.nemo.runtime.executor.data.streamchainer.Serializer;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import java.util.concurrent.ConcurrentLinkedQueue;
+
+/**
+ * This class provides a data transfer interface to the sender side when both
the sender and the receiver are
+ * in the same executor. Since data serialization is unnecessary, the sender
sends data without serializing
+ * them. A single local output context represents a data transfer between two
tasks.
+ */
+public final class LocalOutputContext extends LocalTransferContext implements
OutputContext {
+ private static final Logger LOG =
LoggerFactory.getLogger(LocalOutputContext.class.getName());
+ private ConcurrentLinkedQueue queue = new ConcurrentLinkedQueue();
+ private boolean isClosed = false;
+
+ /**
+ * Creates a new local output context.
+ * @param executorId id of the executor to which this context belong
+ * @param edgeId id of the DAG edge
+ * @param srcTaskIndex source task index
+ * @param dstTaskIndex destination task index
+ */
+ public LocalOutputContext(final String executorId,
+ final String edgeId,
+ final int srcTaskIndex,
+ final int dstTaskIndex) {
+ super(executorId, edgeId, srcTaskIndex, dstTaskIndex);
+ }
+
+ /**
+ * Closes this local output context.
+ */
+ @Override
+ public void close() {
+ if (isClosed) {
+ throw new RuntimeException("This context has already been closed");
+ }
+ queue.offer(Finishmark.getInstance());
+ isClosed = true;
+ // Nullify the reference to the queue for potential garbage collection
+ queue = null;
Review comment:
why do we need this?
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/transfer/LocalInputContext.java
##########
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.nemo.runtime.executor.transfer;
+
+import org.apache.nemo.common.punctuation.Finishmark;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import java.util.Iterator;
+import java.util.concurrent.ConcurrentLinkedQueue;
+
+/**
+ * This class provides a data transfer interface to the receiver side when
both the sender and the receiver are in the
+ * same executor. Since the sender doesn't serialize data, the receiver
doesn't need to deserialize data when retrieving
+ * them.
+ */
+public final class LocalInputContext extends LocalTransferContext {
+ private static final Logger LOG =
LoggerFactory.getLogger(LocalInputContext.class.getName());
+ private ConcurrentLinkedQueue queue;
+ private LocalOutputContext localOutputContext;
Review comment:
Why not final?
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/transfer/LocalInputContext.java
##########
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.nemo.runtime.executor.transfer;
+
+import org.apache.nemo.common.punctuation.Finishmark;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import java.util.Iterator;
+import java.util.concurrent.ConcurrentLinkedQueue;
+
+/**
+ * This class provides a data transfer interface to the receiver side when
both the sender and the receiver are in the
+ * same executor. Since the sender doesn't serialize data, the receiver
doesn't need to deserialize data when retrieving
+ * them.
+ */
+public final class LocalInputContext extends LocalTransferContext {
+ private static final Logger LOG =
LoggerFactory.getLogger(LocalInputContext.class.getName());
+ private ConcurrentLinkedQueue queue;
+ private LocalOutputContext localOutputContext;
+ private boolean isClosed = false;
+
+ /**
+ * Creates a new local input context and connect it to {@param
localOutputContext}.
+ * @param localOutputContext the local output context to which this local
input context is connected
+ */
+ public LocalInputContext(final LocalOutputContext localOutputContext) {
+ super(localOutputContext.getExecutorId(),
+ localOutputContext.getEdgeId(),
+ localOutputContext.getSrcTaskIndex(),
+ localOutputContext.getDstTaskIndex());
+ this.localOutputContext = localOutputContext;
+ this.queue = localOutputContext.getQueue();
+ }
+
+ /**
+ * Closes this local input context.
+ * @throws RuntimeException if the connected output context hasn't been
closed yet, or if there are still data
+ * left to be processed.
+ */
+ @Override
+ public void close() throws RuntimeException {
+ if (!localOutputContext.isClosed()) {
+ throw new RuntimeException("The parent task writer is still sending
data");
+ }
+ if (!queue.isEmpty()) {
+ throw new RuntimeException("There are data left in this context to be
processed");
+ }
+ // Nullify references for potential garbage collection
Review comment:
Why do you nullify? If the context is closed, should we check the
output context queue? whether or not there are remaining events? Maybe we
should guarantee processing all of the events in the output context queue.
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/transfer/LocalInputContext.java
##########
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.nemo.runtime.executor.transfer;
+
+import org.apache.nemo.common.punctuation.Finishmark;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import java.util.Iterator;
+import java.util.concurrent.ConcurrentLinkedQueue;
+
+/**
+ * This class provides a data transfer interface to the receiver side when
both the sender and the receiver are in the
+ * same executor. Since the sender doesn't serialize data, the receiver
doesn't need to deserialize data when retrieving
+ * them.
+ */
+public final class LocalInputContext extends LocalTransferContext {
+ private static final Logger LOG =
LoggerFactory.getLogger(LocalInputContext.class.getName());
+ private ConcurrentLinkedQueue queue;
+ private LocalOutputContext localOutputContext;
+ private boolean isClosed = false;
+
+ /**
+ * Creates a new local input context and connect it to {@param
localOutputContext}.
+ * @param localOutputContext the local output context to which this local
input context is connected
+ */
+ public LocalInputContext(final LocalOutputContext localOutputContext) {
+ super(localOutputContext.getExecutorId(),
+ localOutputContext.getEdgeId(),
+ localOutputContext.getSrcTaskIndex(),
+ localOutputContext.getDstTaskIndex());
+ this.localOutputContext = localOutputContext;
+ this.queue = localOutputContext.getQueue();
+ }
+
+ /**
+ * Closes this local input context.
+ * @throws RuntimeException if the connected output context hasn't been
closed yet, or if there are still data
+ * left to be processed.
+ */
+ @Override
+ public void close() throws RuntimeException {
+ if (!localOutputContext.isClosed()) {
+ throw new RuntimeException("The parent task writer is still sending
data");
+ }
+ if (!queue.isEmpty()) {
+ throw new RuntimeException("There are data left in this context to be
processed");
+ }
+ // Nullify references for potential garbage collection
+ queue = null;
+ localOutputContext = null;
+ isClosed = true;
+ }
+
+ /**
+ * Checks if this context has already been closed.
+ * @return true if this context has already been closed.
+ */
+ public boolean isClosed() {
+ return isClosed;
+ }
+
+ /**
+ * Creates a new iterator which iterates the receive elements from the
sender.
+ * @return iterator that iterates the received elements.
+ */
+ public LocalInputIterator getIterator() {
+ return new LocalInputIterator();
+ }
+
+ /**
+ * Local input iterator that iterates the received elements from the sender.
+ */
+ private class LocalInputIterator implements Iterator {
+ @Override
+ public final boolean hasNext() {
+ if (isClosed) {
+ return false;
+ }
+ while (queue.peek() == null) {
+ continue;
Review comment:
This will lead to spin-loop, which excessively uses CPU cycles. We
should avoid it.
##########
File path:
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/transfer/LocalInputContext.java
##########
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.nemo.runtime.executor.transfer;
+
+import org.apache.nemo.common.punctuation.Finishmark;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import java.util.Iterator;
+import java.util.concurrent.ConcurrentLinkedQueue;
+
+/**
+ * This class provides a data transfer interface to the receiver side when
both the sender and the receiver are in the
+ * same executor. Since the sender doesn't serialize data, the receiver
doesn't need to deserialize data when retrieving
+ * them.
+ */
+public final class LocalInputContext extends LocalTransferContext {
+ private static final Logger LOG =
LoggerFactory.getLogger(LocalInputContext.class.getName());
+ private ConcurrentLinkedQueue queue;
+ private LocalOutputContext localOutputContext;
+ private boolean isClosed = false;
+
+ /**
+ * Creates a new local input context and connect it to {@param
localOutputContext}.
+ * @param localOutputContext the local output context to which this local
input context is connected
+ */
+ public LocalInputContext(final LocalOutputContext localOutputContext) {
+ super(localOutputContext.getExecutorId(),
+ localOutputContext.getEdgeId(),
+ localOutputContext.getSrcTaskIndex(),
+ localOutputContext.getDstTaskIndex());
+ this.localOutputContext = localOutputContext;
+ this.queue = localOutputContext.getQueue();
+ }
+
+ /**
+ * Closes this local input context.
+ * @throws RuntimeException if the connected output context hasn't been
closed yet, or if there are still data
+ * left to be processed.
+ */
+ @Override
+ public void close() throws RuntimeException {
+ if (!localOutputContext.isClosed()) {
+ throw new RuntimeException("The parent task writer is still sending
data");
+ }
+ if (!queue.isEmpty()) {
+ throw new RuntimeException("There are data left in this context to be
processed");
+ }
+ // Nullify references for potential garbage collection
+ queue = null;
+ localOutputContext = null;
+ isClosed = true;
+ }
+
+ /**
+ * Checks if this context has already been closed.
+ * @return true if this context has already been closed.
+ */
+ public boolean isClosed() {
+ return isClosed;
+ }
+
+ /**
+ * Creates a new iterator which iterates the receive elements from the
sender.
+ * @return iterator that iterates the received elements.
+ */
+ public LocalInputIterator getIterator() {
+ return new LocalInputIterator();
+ }
+
+ /**
+ * Local input iterator that iterates the received elements from the sender.
+ */
+ private class LocalInputIterator implements Iterator {
+ @Override
+ public final boolean hasNext() {
+ if (isClosed) {
+ return false;
+ }
+ while (queue.peek() == null) {
+ continue;
+ }
+ return true;
+ }
+
+ @Override
+ public final Object next() throws RuntimeException {
+ if (isClosed) {
+ throw new RuntimeException("This context has already been closed");
+ } else {
+ Object element;
+ while ((element = queue.poll()) == null) {
+ continue;
Review comment:
This will lead to spin-loop, which excessively uses CPU cycles. We
should avoid it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
