jaehwan0214 commented on a change in pull request #304: URL: https://github.com/apache/incubator-nemo/pull/304#discussion_r519583605
########## File path: runtime/executor/src/main/java/org/apache/nemo/runtime/executor/transfer/LocalOutputContext.java ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.nemo.runtime.executor.transfer; + +import org.apache.nemo.common.punctuation.Finishmark; +import org.apache.nemo.runtime.executor.data.streamchainer.Serializer; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import java.util.concurrent.ConcurrentLinkedQueue; + +/** + * This class provides a data transfer interface to the sender side when both the sender and the receiver are + * in the same executor. Since data serialization is unnecessary, the sender sends data without serializing + * them. A single local output context represents a data transfer between two tasks. + */ +public final class LocalOutputContext extends LocalTransferContext implements OutputContext { + private static final Logger LOG = LoggerFactory.getLogger(LocalOutputContext.class.getName()); + private ConcurrentLinkedQueue queue = new ConcurrentLinkedQueue(); + private boolean isClosed = false; + + /** + * Creates a new local output context. + * @param executorId id of the executor to which this context belong + * @param edgeId id of the DAG edge + * @param srcTaskIndex source task index + * @param dstTaskIndex destination task index + */ + public LocalOutputContext(final String executorId, + final String edgeId, + final int srcTaskIndex, + final int dstTaskIndex) { + super(executorId, edgeId, srcTaskIndex, dstTaskIndex); + } + + /** + * Closes this local output context. + */ + @Override + public void close() { + if (isClosed) { + throw new RuntimeException("This context has already been closed"); + } + queue.offer(Finishmark.getInstance()); + isClosed = true; + // Nullify the reference to the queue for potential garbage collection + queue = null; Review comment: This is unnecessary. I removed it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
