jlahoda commented on issue #368: [NETBEANS-251] WidthEstimator is doing estimates based on Symbols, bu? URL: https://github.com/apache/incubator-netbeans/pull/368#issuecomment-357511405 In 8.2, there were no (JDK) modules (and only one unnamed package). I didn't check, but the test was probably written as: t.owner == syms.unnamedPackage So it didn't fail the same way. While we could just fix the test, I think this whole code is just a remnant of handling of FQN names (i.e. printing simple names where possible) in VeryPretty/WidthEstimator. I don't think we are using that now. VeryPretty/WidthEstimator should print the trees as they are. The FQN handling is now done using QualIdents and ImportAnalysis2.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
