vieiro commented on a change in pull request #364: [NETBEANS-252] Fix CG adding
methods to enum constant bodies
URL: https://github.com/apache/incubator-netbeans/pull/364#discussion_r161584355
##########
File path:
java.source.base/src/org/netbeans/modules/java/source/save/CasualDiff.java
##########
@@ -399,6 +405,7 @@ protected CasualDiff(Context context, DiffContext
diffContext, TreeUtilities tre
}
resultSrc = doc.getText(startPos.getOffset(),
endPos.getOffset() - startPos.getOffset());
for (Entry<Object, javax.swing.text.Position[]> e :
spans.entrySet()) {
+ @SuppressWarnings("MismatchedReadAndWriteOfArray") //
NETBEANS-278
Review comment:
This is not required either. As I understand it, It makes reference to a
current bug in the NetBeans editor (as of today) that wrongly marks the next
assignments as not required. This may not be the case in a future version of
NetBeans (i.e, when NETBEANS-278 is solved), so adding the "suppress warnings"
here may be completely irrelevant within two months.
Also adding a reference to a bug report here without any other explanation
may confuse future readers. Think about reading this three months from now: Is
this "SupressWarnings" required to solve NETBEANS-278? Is the whole loop
required to workaround NETBEANS-278? What is NETBEANS-278? Should the reader
open a browser to see what NETBEANS-278 is about? This reviewer was confused by
this and had to open a browser to double-check that. That's a waste of
reviewers time.
This should be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
