vieiro commented on a change in pull request #364: [NETBEANS-252] Fix CG adding
methods to enum constant bodies
URL: https://github.com/apache/incubator-netbeans/pull/364#discussion_r161585085
##########
File path:
java.source.base/src/org/netbeans/modules/java/source/save/CasualDiff.java
##########
@@ -2458,7 +2465,7 @@ protected int diffSelect(JCFieldAccess oldT,
JCFieldAccess newT,
if (nameSpan != null) {
localPointer = nameSpan[1];
} else {
- localPointer = localPointer + oldT.name.length();
+ localPointer += oldT.name.length();
Review comment:
Note that these changes are merely aesthetic. Chaging a = a + b to a += b
does not affect performance, slightly adds more readability, but badly impacts
the time required to review your PR, a time that could have been used for
otherl purposes. As a general rule for next PRs please avoid changing code that
works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
