sarveshkesharwani commented on issue #940: [NETBEANS-1074] Module Review 
web.struts
URL: 
https://github.com/apache/incubator-netbeans/pull/940#issuecomment-429239376
 
 
   @rtaneja1 , There was on overlapping jars warning in verification. I have 
added the changes to `ignored-overlaps` file. I tried running the tests, but 
the tests are failing due to the same reason with/without my changes.
   
   I could not see any place where `struts-config_1_2-custom.dtd` or 
`struts-config_1_3-custom.dtd` are being used in the codebase, so I think it 
would be okay if we don't include them.
   
   I see that there is a merge conflict. I will resolve it and squash the 
commits once this PR is approved.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to