sarveshkesharwani commented on issue #940: [NETBEANS-1074] Module Review 
web.struts
URL: 
https://github.com/apache/incubator-netbeans/pull/940#issuecomment-429801140
 
 
   @matthiasblaesing , I see that instead of collecting the `*.dtd` files from 
different jars, you added them directly along with licenseinfo.xml. The rest of 
your changes also make sense. 
   
   Without `struts-config_1_3-custom.dtd`, was the build failing at the root 
folder? Because, I tried building just the `web.struts` module without 
`struts-config_1_3-custom.dtd` file and the build was passed for the module.
   
   So, we have two options to go forward from here, I can close this PR and you 
can merge your commits, as they contain all the necessary changes exhaustively, 
or I can cherry pick your commits, squash them, and then merge the changes 
through this PR. Which way do you think we should go forward with?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to