matthiasblaesing commented on issue #916: [NETBEANS-1074] Module review j2ee.dd
URL: 
https://github.com/apache/incubator-netbeans/pull/916#issuecomment-430415543
 
 
   @juneau001 I'll start with your build error - lets start how to see it:
   - Click on "details" behind the travis check - you now get to the travis-ci 
web interface
   - Click on the failing job - you'll see the normal output (incomplete)
   - Click on "Raw log" - you'll get to: 
https://api.travis-ci.org/v3/job/441151558/log.txt
   - Now look for "Build failed" and you'll get:
   
   ```
   travis_time:start:00449ade
   $ if [ "x$LICENSE" == "xtrue" ]; then ant -quiet 
verify-libs-and-licenses -Dverify-libs-and-licenses.haltonfailure=true; fi
        [echo] Bootstrapping NetBeans-specific Ant extensions...
        [echo] Downloading external binaries (*/external/ directories) for 
cluster.config=release...
   [verifylibsandlicenses] Warning: 
org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 
'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not 
recognized.
   [verifylibsandlicenses] Compiler warnings:
   [verifylibsandlicenses]   WARNING:  'org.apache.xerces.jaxp.SAXParserImpl: 
Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not 
recognized.'
   
   BUILD FAILED
   /home/travis/build/apache/incubator-netbeans/nbbuild/build.xml:1532: Failed 
VerifyLibsAndLicenses test(s):
   Some licenseinfo.xml files failed verification:
   enterprise/j2ee.dd/licenseinfo.xml referenced file not found 
'src/org/netbeans/modules/j2ee/dd/impl/resources/java_web_services_client_1_1.xsd'
   ```
   
   You can get the full check on your system by running:
   ```
   ant -Dcluster.config=enterprise verify-libs-and-licenses
   ```
   from the root of the repository. The output can be found in: 
`nbbuild/build/verifylibsandlicenses.xml`. Look only for failures referencing 
the module you are working on.
   
   Long story short: Your `licenseinfo.xml` references a file, that is not 
present.
   
   The build failure is IMHO minor - a bigger problem is, that your 
`licenseinfo.xml` makes invalid license claims.
   
   - You need to create one fileset per license/comment tuple and I think this 
is the main problem.
   - You imported the XSDs. Most, if not all, DTDs/XSDs Oracle/Sun created for 
Open Source projects are dual-licenses as GPLv2-CPE/CDDL. For the Apache 
Netbeans Project we elect the CDDL as the license. Yet the file declares: 
`<license ref="Apache-2.0-ASF" />`. You need to check the individual files 
(they all should contain a license statement), but most probably are 
GPLv2-CPE/CDDL-1.1 and thus a correct entry would be `<license ref="CDDL-1.1" 
/>` for these.
   - you declare `<comment type="COMMENT_UNSUPPORTED"/>` that is correct for 
the `doc/dd_api_schema.jpg` file. The comment should give a reasoning why the 
file can/needs to be included. For the schemas we include them because we use 
the schemas at runtime for XML validation and code completion. The CDDL can be 
included (https://www.apache.org/legal/resolved.html#category-b, last 
paragraph). The prepared comment for that is "CATEGORY-B". If you read the FAQ 
entry the name becomes clear :-)
   
   So please:
   - check the files if valid license headers/license info is present, if not 
please try to find a good copy (for the standard a good source 
is:https://search.maven.org/artifact/org.glassfish.main.appclient/gf-client-module/5.0/glassfish-jar,
 for W3C files please look on the W3C site)
   - If the file is from the W3C, the license is most probably `W3C-2` (the 
current version of the W3C software license). Please see 
`enterprise/web.core/src/org/netbeans/modules/web/taglib/resources/xml.xsd` and 
`enterprise/web.core/licenseinfo.xml` for a sample. I added the license header 
to the file and documented that inline.
   - The JavaEE XSDs normally have valid headers (see discussion about license 
above). It just needs to be checked, that it is ok.
   - Group the files by license and comment and add `fileset` entries for each 
group of file to `licenseinfo.xml`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to