matthiasblaesing commented on issue #916: [NETBEANS-1074] Module review j2ee.dd URL: https://github.com/apache/incubator-netbeans/pull/916#issuecomment-434092432 Thank you for the updated PR. In general this looks good. I noticed this: - `web-app_2_2.dtd` is declared as originate from the W3C. I doubt that. Judging from the other descriptors, I would replace it with a copy from here: `https://www.jcp.org/j2ee/dtds/web-app_2_2.dtd` and adjust the `licenseinfo.xml` accordingly - `web-app_2_3.dtd` looks strange (the license is unconventional) - this copy hold a cleaner license: https://www.jcp.org/dtd/web-app_2_3.dtd. Both files can also be found in the following glassfish artifact: https://search.maven.org/artifact/org.glassfish.main.appclient/gf-client-module/5.0/glassfish-jar Given that oracle was the distributor/developer of glassfish this would be a safe source. With these files updated, I would merge.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
