sdedic commented on a change in pull request #1039: [NETBEANS-1743] Ignores
NbLifecycleManager exit call while already ex…
URL:
https://github.com/apache/incubator-netbeans/pull/1039#discussion_r237775498
##########
File path: platform/o.n.core/src/org/netbeans/core/NbLifecycleManager.java
##########
@@ -169,6 +169,10 @@ private void finishExitState(CountDownLatch cdl, boolean
clean) {
@Override
public void exit(int status) {
+ if (isExiting()) {
Review comment:
I think this guard breaks behaviour specified in `LifecycleManager.exit` API
docs. The call should not return if the system is (still) willing to exit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
