emilianbold commented on issue #1039: [NETBEANS-1743] Ignores NbLifecycleManager exit call while already ex… URL: https://github.com/apache/incubator-netbeans/pull/1039#issuecomment-443135874 Hm, then I think I could just log a WARN that an exit is ongoing. I don’t want to block this thread because I might deadlock things. --emi Pe 30 nov. 2018, la 10:15, Svatopluk Dedic <[email protected]> a scris: > @sdedic commented on this pull request. > > In platform/o.n.core/src/org/netbeans/core/NbLifecycleManager.java: > > > @@ -169,6 +169,10 @@ private void finishExitState(CountDownLatch cdl, boolean clean) { > > @Override > public void exit(int status) { > + if (isExiting()) { > I think this guard breaks behaviour specified in LifecycleManager.exit API docs. The call should not return if the system is (still) willing to exit. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub, or mute the thread.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
