emilianbold commented on a change in pull request #1011: Enhanced wrapper for 
Scripting API 
URL: 
https://github.com/apache/incubator-netbeans/pull/1011#discussion_r239027245
 
 

 ##########
 File path: 
enterprise/web.jsf/src/org/netbeans/modules/web/jsf/palette/JSFPaletteUtilities.java
 ##########
 @@ -242,7 +240,7 @@ protected static ScriptEngine getScriptEngine(FileObject 
fo) {
                     } catch (ClassNotFoundException ex) {
                         Exceptions.printStackTrace(ex);
                     }
-                    manager = new ScriptEngineManager(loader != null ? loader 
: Thread.currentThread().getContextClassLoader());
 
 Review comment:
   Why is loader ignored here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to