emilianbold commented on a change in pull request #1011: Enhanced wrapper for Scripting API URL: https://github.com/apache/incubator-netbeans/pull/1011#discussion_r244097266
########## File path: platform/api.scripting/src/org/netbeans/modules/scripting/GraalEnginesProvider.java ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.netbeans.modules.scripting; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import javax.script.ScriptEngineFactory; +import org.graalvm.polyglot.Engine; +import org.graalvm.polyglot.Language; +import org.netbeans.spi.scripting.EngineProvider; +import org.openide.util.lookup.ServiceProvider; + +@ServiceProvider(service = EngineProvider.class) Review comment: I still find this an abuse of the module system. Why compile the code is this weird way, add a compile time dependency on Graal and have .class files that are un-loadable when we could have a separate module for people to load when Graal is there? Maybe have a token or something for GraalVM (something for `OpenIDE-Module-Java-Dependencies` perhaps) ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
