jlahoda commented on a change in pull request #1138: [NETBEANS-2038] Do not dump ambiguous output when a build is cancelled. URL: https://github.com/apache/incubator-netbeans/pull/1138#discussion_r257491682
########## File path: groovy/gradle/src/org/netbeans/modules/gradle/execute/EscapeProcessingOutputStream.java ########## @@ -29,9 +29,10 @@ * @author Laszlo Kishalmi */ class EscapeProcessingOutputStream extends OutputStream { - + boolean esc; boolean csi; + boolean closed = false; Review comment: I wonder if some kind of synchronization is needed for the field? (Maybe AtomicBoolean instead of plain boolean?) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists