jlahoda commented on a change in pull request #1138: [NETBEANS-2038] Do not dump ambiguous output when a build is cancelled. URL: https://github.com/apache/incubator-netbeans/pull/1138#discussion_r257491644
########## File path: groovy/gradle/src/org/netbeans/modules/gradle/execute/GradleDaemonExecutor.java ########## @@ -167,12 +168,15 @@ public void run() { buildLauncher.run(); StatusDisplayer.getDefault().setStatusText(Bundle.BUILD_SUCCESS(getProjectName())); } catch (BuildCancelledException ex) { - try { - IOColorPrint.print(io, "\nBUILD ABORTED\n", IOColors.getColor(io, IOColors.OutputType.ERROR)); //NOI18N - } catch (IOException iex) { - } + showAbort(); } catch (UncheckedException | BuildException ex) { - StatusDisplayer.getDefault().setStatusText(Bundle.BUILD_FAILED(getProjectName())); + if (!cancelling) { + StatusDisplayer.getDefault().setStatusText(Bundle.BUILD_FAILED(getProjectName())); + } else { + // This can happen if cancelling a Gradle build which is running + // an external aplication + showAbort(); + } //TODO: Handle Cancelled builds Review comment: Nit: these comments are probably obsolete now? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists