maxcuttins commented on issue #1234: FIX: SASS integration is broken - removed old parameter "--cache-location" URL: https://github.com/apache/netbeans/pull/1234#issuecomment-535264592 > I wanted to merge, but while testing I observed two things: > > 1. @maxcuttins please ensure that your author information in git is valid. Your author email ends with "@users.noreply.github.com" I guess it's overwritten by GitHub. Any Idea how to avoid this behavior? (Maybe this was due that I just fix the code directly from the Web GUI instead of clone the entire repo). If somebody can help me avoid this I'll place my email without problems. > 2. This changeset introduces a regression for ruby sass users. Without the "--cache-location" parameter, the cache is placed into the `public_html` directory. That way it pollutes the work space of the user. This is right but should be left as it is. 1) the Ruby version is supported but deprecated and should not be used anymore. 2) if you still want to use the Ruby version, you can always add all the arguments that you need on the command line in the Project Properties in order to get the behaviour you want. Everybody use the command line option to add `--style=compressed`. If Ruby folks have to add also `--cache-location` on old version of SASS I think is quite acceptable and not so a bad deal instead to have a broken compilar for anybody else. I think we should avoid to hard-code old/deprecated/distribution-specific arguments that will break any other version of SASS. > What do you think about this idea: use the "--help" call to see which options are supported. If an option is listed, it can be used (this assumes, that they are compatible). Are you talking about cast everytime `--help` to SASS, parse the output, get the options, strip the descriptions, check the arguments and create a whitelist of arguments to use? If I get this right (maybe not) this is tons of hours of work in order to obtain a fragile parser which is subject to brake up everytime the format of the help change. As far as I can see SASS changes a lot its formats, it come from `snake_style` arguments to `camelStyle` arguments. So I'll not going to put any effort to try to parse something that is written from a team of people that changes their mind so rapidly and make so much code break changes. Of course it's just my opinion
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
