maxcuttins commented on issue #1234: FIX: SASS integration is broken - removed old parameter "--cache-location" URL: https://github.com/apache/netbeans/pull/1234#issuecomment-535844119 > > ## Technical issue > > I had another look in the code and @peedeeboy already gave the right hint. NetBeans allows switching from the original sass implementation to libsass based implementations via a system property `nb.sass.libsass`. with any recent netbeans installation: > > * run `<PATH_TO_NETBEANS>/bin/netbeans -J-Dnb.sass.libsass=true` > Maybei'm in wrong (probably) but I don't think that this is can be set by GUI interface. > > ```java > private static final boolean USE_LIBSASS = Boolean.parseBoolean(System.getProperty("nb.sass.libsass", "true")); // NOI18N > ``` I didn't know that there was already a property available in order to switch the type of SASS. > The above code updated in `SassCli`, line 56 will switch the default from ruby sass to libsass. Anyone requiring ruby sass, can run with `nb.sass.libsass=false`. This needs to be tested of course. By having already a property, this is defintly the best way to go. However, we have to check if the property can be switched easily. > For your concrete problem: You most probably set the option "Keep my email addresses private` in you Settings (Personal settings -> Emails). Thanks! Checked just yesterday after my post. It was exactly how you write. > > IMHO this is not a valid way to contribute. It can be argued, that the change is small enough to be doable from a WebGUI, you obvisously did not run UnitTests for the changeset. I know and I agree with you, exactly as you wrote the argued is this fix was just about remove an argument `--command` from the CLI command of SASS. This was doable from any kind of editor and without tests.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
