lbruun opened a new pull request #1844: [NETBEANS-2523] Installer creates invalid Win Registry value URL: https://github.com/apache/netbeans/pull/1844 The `WindowsRegistry_set32BitValue0()` function was incorrectly using the length of the Registry name (e.g. 'NoModify') as the the length of value. Since the Registry value we are setting is of type DWORD the length is indeed always exactly 4 bytes, regardless of OS bitness. Solution: `sizeof(dword)` will always return 4, but we might as well have hard-coded the 4. Impact: The impact of bug has been seen when NBI sets the `NoModify` registry value in the `Uninstall` section of the Registry. The bug has existed for years but has only minor impact, for example with system analyzers flagging the 'NoModify' value as suspect or not being able to read the value with tools such as Powershell.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
