lbruun edited a comment on issue #1844: [NETBEANS-2523] Installer creates 
invalid Win Registry value
URL: https://github.com/apache/netbeans/pull/1844#issuecomment-571921984
 
 
   @rtaneja1 
   The actual build process for these NBI artifacts is a blur to me.  That was 
the case even in the pre-Apache days.
   
   I can tell you how it is meant to be:
   
   The build result of the project we've just changed is a (quite small) `.dll` 
file. This lib is a helper library for the NBI Engine and thus gets physically 
embedded inside `nbi-engine.jar`. (if you open up a copy of `nbi-engine.jar` 
you'll find a path called `native/jnilib/windows/` where it lives). The `.dll` 
library is only used from Java code (it is JNI stuff) and is as such unrelated 
to `nlw.exe` which is simply the launcher for that Java code..
   
   As I said my knowledge of the build process is near zero. What I wonder 
myself are:
   
   1. Have we actually triggered a new build of the `.dll`. If so, where did 
the build result go?
   2. How does the build result, the .dll file, get embedded into 
`nbi-engine.jar` ?. Do we need to trigger that build too?
   
   I believe that even in the pre-Apache days there were manual steps involved 
but that is just a hunch.
   
   In the end the test of the change is simple:  Do an install of the IDE 
itself using installer (.exe) and when finished open `regedit.exe`. Have a look 
at the screenshot in 
[NETBEANS-2523](https://issues.apache.org/jira/browse/NETBEANS-2523). The 
yellow highlight is what goes wrong. It should display the value "1" instead of 
displaying "(invalid DWORD (32-bit) value)".
   
   For some time I've had my own version of NBI (all components) with this bug 
fixed. This is why I know it works. I'm now trying to bring the fix back into 
mainline NetBeans.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to