lahodaj commented on a change in pull request #1890: [NETBEANS-3693] Create
only one instance of javac
URL: https://github.com/apache/netbeans/pull/1890#discussion_r369128641
##########
File path:
java/java.source.base/src/org/netbeans/modules/java/source/parsing/JavacParser.java
##########
@@ -415,9 +422,28 @@ private void parseImpl(
break;
default:
init (snapshot, task, false);
+ DiagnosticListener<JavaFileObject> diagnosticListener;
Review comment:
I was hoping this could work in such a way that if the processing of the
files does not fit into memory, it would fall back to the slow "one javac per
file". It is not as good as current nb-javac, but I hope it would work
reasonably OK. Would also be good to have some tests for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
