Akshay-Gupta-Oracle commented on issue #1890: [NETBEANS-3693] Create only one instance of javac URL: https://github.com/apache/netbeans/pull/1890#issuecomment-584013441 > > > Left some initial comments. Please note that at least the "org.netbeans.modules.java.source.parsing.JavacParserTest" appears to be failing. > > > > > > There is one test case failing - testMultiSourceVanilla > > Which has the statement - "assertFalse(Objects.equals(storedJLObject, jlObject));" which I think will not pass when only one instance of javac is created. > > Right - but that means the test needs to be fixed (or removed), correct? I.e. we cannot have failing tests, I assume? Yes, will do that.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
