errael opened a new pull request #1991: [NETBEANS-3918] defer creation of target folder until/if needed URL: https://github.com/apache/netbeans/pull/1991 Without this change, there is some directory creation in BasicPanelVisual.store, but that method is called in several situations where directory/DataFolder creation should not occur. This PR moves the creation code to TemplateWizard.getTargetFolder(), which defers the creation until needed. Unfortunately, with a breakpoint, I have not seen getTargetFolder() invoked when creating a maven project. This PR is designed to preserve semantic; it is highly targeted and relatively simple. There may be better/simpler/more-direct fixes; but I am unfamiliar with the overall architecture; revset which introduced the spurious directory creation: ``` changeset: 301468:76d9cafcee35 branch: ArchetypesUI268677 parent: 299970:0c5aa5cdb86a user: Jaroslav Tulach <[email protected]> date: Tue Oct 25 21:52:49 2016 +0200 summary: #268677: Recognizing .archetype template files and using them to instantiate projects via mvn archetype ``` This simplest fix would be to simply remove the directory creation from BasicPanelVisual and not put it in getTargetFolder(). This would fix the cases I have seen; in those cases the directory is created by maven project instantiation and the data fold is not referenced. But this would not preserve semantics around TemplateWizard and DataFolder. This PR also fixes [NETBEANS-3875] which is about failure of maven artifact creation.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
