errael commented on issue #1991: [NETBEANS-3918] defer creation of target folder until/if needed URL: https://github.com/apache/netbeans/pull/1991#issuecomment-593201834 Some time after seeing the earlier build failure, my subconscious informed me of a minor semantic difference. Previously `wiz.setTargetFolder(null); wiz.getTargetFolder();` would throw an assertion. Along with changing method name to setTargetFolderLazy, in setTargetFolder I've added ``` if (LOG.isLoggable(Level.FINE)) { LOG.log(Level.FINE, "set targetFolder=" + f + " for " + this, new Throwable()); } + if(f == null) { + targetDataFolderCreator = null; + } targetDataFolder = f; } ``` This maintains semantics AFAICT. And set java/maven dependency to 7.76
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
