matthiasblaesing commented on a change in pull request #2000: Adding full
support for Wildfly 17, 18
URL: https://github.com/apache/netbeans/pull/2000#discussion_r392367462
##########
File path: contrib/javaee.wildfly/licenseinfo.xml
##########
@@ -47,4 +52,26 @@
<license ref="W3C2" />
<comment type="CATEGORY_B" />
</fileset>
+ <fileset>
+
<file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-app_4_0.dtd</file>
+
<file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-service_4_0.dtd</file>
+
<file>src/org/netbeans/modules/javaee/wildfly/resources/jboss_4_0.dtd</file>
+
<file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_7_3.xsd</file>
+
<file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_4_0.dtd</file>
+
<file>src/org/netbeans/modules/javaee/wildfly/resources/datasources_1_4.xsd</file>
+
<file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_6_0.xsd</file>
+
<file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-as-messaging-deployment_1_0.xsd</file>
+
<file>src/org/netbeans/modules/javaee/wildfly/resources/wildfly-messaging-activemq-deployment_1_0.xsd</file>
+ <license ref="LGPL-2.1" />
+ <comment type="CATEGORY_B" />
+ </fileset>
+ <fileset>
+
<file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_14_1.xsd</file>
+
<file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-app_8_1.xsd</file>
+
<file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-common_8_1.xsd</file>
+
<file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-ejb3-2_1.xsd</file>
+
<file>src/org/netbeans/modules/javaee/wildfly/resources/jboss-web_14_1.xsd</file>
+ <license ref="Apache-2.0-ASF" />
+ <comment type="COMMENT_UNSUPPORTED" />
Review comment:
The "ref" points to the license in the nbbuild/licenses folder. For each
license there can the full text be found. In this case "Apache-2.0-ASF" starts
with "Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements." That statement would be wrong for foreign
code, so the correct variant is "Apache-2.0".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
