oyarzun commented on a change in pull request #2015:
URL: https://github.com/apache/netbeans/pull/2015#discussion_r430404353
##########
File path: nbi/engine/build.xml
##########
@@ -20,10 +20,17 @@
-->
-<project name="NBI_Engine" default="default" basedir=".">
+<project name="nbi/engine" default="default" basedir=".">
Review comment:
@arusinha & @ebarboni It can wait until 12.1 since this has been broken
since version 10. Plus there are ways around it, create one installer for Java
8 and another for Java 11+.
I do not use this feature and only started looking at it since we switched
our RCPs builds to use maven. In maven there is no goal to build a macOS
application like there is with ant.
https://issues.apache.org/jira/browse/NETBEANSINFRA-37
##########
File path: nbi/engine/build.xml
##########
@@ -20,10 +20,17 @@
-->
-<project name="NBI_Engine" default="default" basedir=".">
+<project name="nbi/engine" default="default" basedir=".">
Review comment:
@arusinha
I've found a work around that allows the NB installer to be built. Since it
is not used for macOS we don't need the mac specific classes that are loaded by
reflection. Create a copy of the original nbi/engine build.xml in
nbbuild/installer/infra/build/build-nbi-engine.xml then patch it's build.xml as
follows.
```diff
diff --git a/nbbuild/installer/infra/build/build.xml
b/nbbuild/installer/infra/build/build.xml
index 4861fc7092..94134b2634 100644
--- a/nbbuild/installer/infra/build/build.xml
+++ b/nbbuild/installer/infra/build/build.xml
@@ -71,8 +71,13 @@
<exclude name="infra/server/**/build/**/*.*"/>
<exclude name="infra/server/**/dist/**/*.*"/>
<exclude name="infra/server/**/private/**/*.*"/>
+ <!-- macOS uses native installer so ignore initialize macOS
classes loaded with reflection -->
+ <exclude
name="engine/src/org/netbeans/installer/wizard/containers/InitializeMacJDK8.java"/>
+ <exclude
name="engine/src/org/netbeans/installer/wizard/containers/InitializeMacJDK9.java"/>
</fileset>
</copy>
+ <!--replace nbi/engine build.xml with one that does not build the
initialize macOS classes -->
+ <copy file="build-nbi-engine.xml"
tofile="${nbi.core.dir}/engine/build.xml" overwrite="true"/>
<copy todir="${nbi.netbeans.dir}">
<fileset dir="${hg.root}/installer">
<exclude name="infra/server/**/build/**/*.*"/>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
