oyarzun commented on a change in pull request #2015:
URL: https://github.com/apache/netbeans/pull/2015#discussion_r431425037
##########
File path: nbi/engine/build.xml
##########
@@ -20,10 +20,17 @@
-->
-<project name="NBI_Engine" default="default" basedir=".">
+<project name="nbi/engine" default="default" basedir=".">
Review comment:
@arusinha I like the idea of a property, but I tried changing the
relative path. I ran into the same problem with projectized.xml which made me
change the project name. The new path causes this check to fail when building
the NB installer.
```xml
<property name="ant.file.1" location="${ant.file}"/>
<property name="ant.file.2"
location="${nb_all}/${ant.project.name}/build.xml"/>
<fail message="Please keep the Ant project name the same as the
project's directory name: ${ant.file.1} vs. ${ant.file.2}">
<condition>
<not>
<equals arg1="${ant.file.1}" arg2="${ant.file.2}"/>
</not>
</condition>
</fail>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
