BradWalker commented on pull request #2194: URL: https://github.com/apache/netbeans/pull/2194#issuecomment-646409610
> Many of the changes aren't API changes (like changing local variables and private or package private field/method types). Those can certainly be made, the other ones would deserve some more thoughts. We have just a single try to get the signatures right! > > However let me state that it makes no sense to reduce number of warnings without preventing the warnings to ever appear again. E.g. for each module that you want to clean up, turn on "warning as error" mode and then fix (or suppress) all the warnings in the module. Otherwise it is just a useless mangling of the source code. In my 2 Kč opinion. I'm in agreement with you about this.. But, there are 10s of thousands of warnings.. I'm trying to fix things in a way that only "one thing" gets changed at a time.. That's why I'll do things like just fix the EMPTY_LIST.. I've managed to get our number of warnings down from approx. 26,000 to 19,000.. Once things get more manageable then we can start to turn on "error on warning".. Hopefully this explains my rational better.. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
